Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add how to install requirements on different stages to Workflow for layered requirements section. #1044

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Add how to install requirements on different stages to Workflow for layered requirements section. #1044

merged 1 commit into from
Jan 30, 2020

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jan 26, 2020 •
edited by atugushev
Loading

Fix #1043

Changelog-friendly one-liner: Add how to install requirements on different stages to Workflow for layered requirements section.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@hramezani hramezani added docs Documentation related good first issue A good item for first time contributors to work on labels Jan 26, 2020
@codecov
Copy link

codecov bot commented Jan 26, 2020 •
edited
Loading

Codecov Report

Merging #1044 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1044   +/-   ##
======================================
  Coverage    99.5%   99.5%           
======================================
  Files          34      34           
  Lines        2418    2418           
  Branches      306     306           
======================================
  Hits         2406    2406           
  Misses          6       6           
  Partials        6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0170297...4387fe8. Read the comment docs.

atugushev
atugushev reviewed Jan 28, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@atugushev atugushev removed the good first issue A good item for first time contributors to work on label Jan 28, 2020
@atugushev
Copy link
Member

FTR, detached "good-first-issue" label, since it's related only to issues.

@atugushev atugushev added this to the 4.4.1 milestone Jan 30, 2020
atugushev
atugushev approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atugushev atugushev merged commit 785151c into jazzband:master Jan 30, 2020
@atugushev
Copy link
Member

@hramezani thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

Update workflow for layered requirements in README
2 participants
@hramezani @atugushev