Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary envvar configuration in click options #1238

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Remove unnecessary envvar configuration in click options #1238

merged 1 commit into from
Nov 25, 2020

Conversation

jdufresne
Copy link
Member

@jdufresne jdufresne commented Nov 22, 2020 •
edited
Loading

These are environment variables consumed by pip. As environment
variables are passed through to subprocesses they're already handled. No
special processing in pip-tools is required so simplify the CLI
definition

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@jdufresne jdufresne added the cli Related to command line interface things label Nov 22, 2020
@jdufresne jdufresne added this to the 5.5.0 milestone Nov 22, 2020
atugushev
atugushev approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jdufresne
Remove unnecessary envvar configuration in click options
3f62794 
These are environment variables consumed by pip. As environment
variables are passed through to subprocesses they're already handled. No
special processing in pip-tools is required so simplify the CLI
definition.
@jdufresne jdufresne merged commit d786232 into jazzband:master Nov 25, 2020
@jdufresne jdufresne deleted the envvar branch November 25, 2020 20:15
@AndydeCleyre AndydeCleyre mentioned this pull request Mar 24, 2021
Merged
3 tasks
@AndydeCleyre
Copy link
Contributor

Missed a spot:

@pytest.fixture(autouse=True)
def _temp_dep_cache(tmpdir, monkeypatch):
    monkeypatch.setenv("PIP_TOOLS_CACHE_DIR", str(tmpdir / "cache"))

See also #1357 (discussion)

webknjaz
webknjaz reviewed Mar 24, 2021
View reviewed changes
piptools/scripts/compile.py
@@ -216,9 +210,7 @@ def has_arg(self, arg_name):
"--cache-dir",
help="Store the cache data in DIRECTORY.",
default=CACHE_DIR,
envvar="PIP_TOOLS_CACHE_DIR",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref #1357 (comment)

AndydeCleyre added a commit to AndydeCleyre/pip-tools that referenced this pull request Mar 25, 2021
@AndydeCleyre
Restore ability to set compile cache with env var PIP_TOOLS_CACHE_DIR
6986bd3 
Fixes bug introduced in jazzbandGH-1238 and exposed by jazzbandGH-1357
@AndydeCleyre AndydeCleyre mentioned this pull request Mar 25, 2021
Merged
3 tasks
atugushev pushed a commit that referenced this pull request Mar 25, 2021
@AndydeCleyre
Restore ability to set compile cache with env var PIP_TOOLS_CACHE_DIR (…
2dd787a 
…#1368)

Fixes bug introduced in GH-1238 and exposed by GH-1357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
cli Related to command line interface things
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jdufresne @AndydeCleyre @webknjaz @atugushev