-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for EOL Python 3.5 and 2.7 #1243
Merged
Merged
Commits on Dec 30, 2020
-
Run pyupgrade for minor code cleanup
https://github.com/asottile/pyupgrade Cleanups: - set comprehension - drop default open() argument
Configuration menu - View commit details
-
Copy full SHA for f12de9a - Browse repository at this point
Copy the full SHA f12de9aView commit details -
Remove testing for EOL Python 3.5
Python 3.5 went EOL 2020-09-30. For a list of supported Python versions, see: https://devguide.python.org/#status-of-python-branches For a list of EOL Python versions and their dates, see: https://devguide.python.org/devcycle/#end-of-life-branches
Configuration menu - View commit details
-
Copy full SHA for de00f69 - Browse repository at this point
Copy the full SHA de00f69View commit details -
Remove support for EOL Python 2.7
Python 2.7 went EOL 2020-01-01. For a list of supported Python versions, see: https://devguide.python.org/#status-of-python-branches For a list of EOL Python versions and their dates, see: https://devguide.python.org/devcycle/#end-of-life-branches Removing support reduces compatibility code, CI resources, and other maintenance concerns. As well, can begin to take advantage of newer Python features and patterns. Cleanups: - Use f-strings - Drop __future__ imports - Drop file encoding cookies "# coding: utf-8" - Drop uses of six - Use stdlib TemporaryDirectory and unittest.mock - Use newer metaclass syntax - Drop now unnecessary fs_str() function - Drop inheritance from "object", all Python 3 classes are new-style classes - Remove unnecessary coerce to string/bytes calls - Use updated subprocess APIs
Configuration menu - View commit details
-
Copy full SHA for 78ae8fb - Browse repository at this point
Copy the full SHA 78ae8fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 921bbfd - Browse repository at this point
Copy the full SHA 921bbfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b81f222 - Browse repository at this point
Copy the full SHA b81f222View commit details -
Simplify tests using standard pytest tooling
- Monkey patch sys.stdin using io.StringIO(). This avoids the need to use yet-another-tool rather than the tools providing by the test library. - This reduces indentation to slightly improve readability. - Allows for more accurate assertion of stdout and stderr.
Configuration menu - View commit details
-
Copy full SHA for eac81c5 - Browse repository at this point
Copy the full SHA eac81c5View commit details -
Prefer capsys instead of capfd
capfd was used to workaround a compatibility issue between Python 2, Windows and Click. With Python 2 gone, can use capsys.
Configuration menu - View commit details
-
Copy full SHA for d9ade3c - Browse repository at this point
Copy the full SHA d9ade3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9575ef - Browse repository at this point
Copy the full SHA a9575efView commit details -
Configuration menu - View commit details
-
Copy full SHA for f63953e - Browse repository at this point
Copy the full SHA f63953eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.