Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing --no-upgrade option #1438

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Allow passing --no-upgrade option #1438

merged 2 commits into from
Jul 1, 2021

Conversation

ssbarnea
Copy link
Member

This makes this option similar with the other boolean ones and allows
calling the tools with explicit --no-upgrade.

This change ease integration with other tools like CI/CD pipelines
where user may want to change the default behavior related to
upgrades.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

This makes this option similar with the other boolean ones and allows
calling the tools with explicit --no-upgrade.

This change ease integration with other tools like CI/CD pipelines
where user may want to change the default behavior related to
upgrades.
@ssbarnea ssbarnea added this to the 6.3.1 milestone Jun 28, 2021
@ssbarnea ssbarnea requested a review from atugushev June 28, 2021 13:49
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Maybe "enhancement"?

@ssbarnea
Copy link
Member Author

ssbarnea commented Jul 1, 2021

LGTM 👍 Maybe "enhancement"?

I see it a as a bugfix, and I do not want to wait until 6.3.0 is ready, especially as lack of it prevents use with tox posargs where I want to do something like

command = pip-compile {posargs:--upgrade} ....

This construct allows running that tox env with only compilation and still allow user to call it with tox -e envname -- --no-upgrade to disable the implicit upgrade (something very useful for CI pipeline, where we only want to check if compile deps are valid, not to upgrade all deps).

@ssbarnea ssbarnea merged commit 8b5b3b6 into master Jul 1, 2021
@ssbarnea ssbarnea deleted the fix/no-upgrade branch July 1, 2021 10:21
@atugushev atugushev modified the milestones: 6.2.1, 6.3.0 Jul 17, 2021
@atugushev atugushev changed the title Allow passing --no-upgrade option Allow passing --no-upgrade option Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants