-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instantiate a new accumulator InstallRequirement
for combine_install_requirements
output
#1519
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
828e2d6
Partially revert "Fix a regression where multiple declarations of a d…
richafrank 46ec202
Failing test for case of resolver combining extras after the first
richafrank 34a2416
Integration test for #1505
richafrank 41b4d37
Integrate microcat49's attribute copying fix for lost local req info
AndydeCleyre b11a5c1
Added test for lost local req info
richafrank a9e647a
re-resolve dependencies of combined install_requirement
f35a7ba
Make a new InstallRequirement instance instead of mutating a copy
richafrank 351e126
Removed unused parameter
richafrank b065118
No longer need the name proxy, now that we're not mutating InstallReq…
richafrank d8b9135
Simplify unit test, so it's not so implementation-specific.
richafrank 97471ea
Test the entire resolver output
richafrank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this change to make this behavior consistent with the cached dependencies case, tests failed because the output included markers, e.g.
fake-tensorboardx==0.5; extra == "tune"
.