Ensure pip-compile --dry-run --quiet
still shows what would be done, while omitting the dry run message
#1592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845
Original title: "Ensure
pip-compile --dry-run --quiet
logs the result (without the dry run message) to stderr"As the purpose of
--dry-run
according to our--help
docs is to "...show what would happen...", that bit of logging should not be silenced by--quiet
, so we herein bypass the log level filtering by usinglog.log
rather thanlog.info
for the output during dry runs.The corresponding dry+quiet test has been updated accordingly.
I also changed our basic testing of
--quiet
by removing the--dry-run
option and additionally checking that stdout is empty.Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.