-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --all-extras
flag to pip-compile
#1630
Conversation
acd7e78
to
cb5216f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great idea! A few comments.
The goal is to make it easy to compile version locks for all runtime dependencies in a way that is robust to human error. By using the wildcard extra the risk of forgetting to list any extra is removed. Since the expanded extras are needed when we look for the wildcard it is moved to before the loop. This is OK because it does not depend on the loop and nothing in the loop depends on its previous value.
a0cff0f
to
76ac553
Compare
... to not give users the misleading impression that pattern matching, with regex, fnmatch or some other system, works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@apljungquist could you please update the PR title?
--extra
--all-extras
flag to pip-compile
Certainly. Thanks for being patient and guiding me through the process. |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
The goal is to make it easy to compile version locks for all runtime
dependencies in a way that is robust to human error. By using the
wildcard extra the risk of forgetting to list any extra is removed.
Is this a use case pip-tools wants to support?
If yes, is the current approach a good one?
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.