-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated compatibility matrix from README
#1950
Conversation
As noted in #1937, this matrix is out of date now that https://github.com/jazzband/pip-tools/releases/tag/7.0.0 has shipped. Technically it could be kept around and add some more rows, but I don't think it's worth the effort... it will always be going out of date. Instead, let the internal dep constraints within `setup.py`/`pyproject.toml` constrain what versions of `python` / `pip` are compatible with that version of `pip-tools`. Most users won't care, but those who will can access that data manually. And otherwise it'll all be smoothly resolved by package managers. So let's just remove it altogether.
Though this only provides constraints for the current version, throwing away the carefully curated information about historical versions. At least there should be a general note about compatibility. |
I don't follow... Were these dep / classifier versions not pinned in previous releases? It's not hard to look at the contents of a file for a particular release tag... My point was that very few users care about this information and for those who do it's not hard to retrieve that data. If they weren't pinned in the past, well, then yeah might be tough to find without trial and error. Regardless, now that 3.6 (and now even 3.7) is eol'd and I see more and more packages dropping support for them, won't be too long until there won't be much demand for a package manager that supports older python versions simply because there aren't package updates available. |
Well yes, that's true. Hadn't thought of the possibility of digging through the tags. Then maybe could you keep the introduction of that section, but remove the table and say that required |
Cool, yeah, some days it feels like I spend hours doing
I personally don't think that section has enough value to merit being on the Users won't care until they run into a problem, in which case they'll google / stackoverflow / start looking at And when it's not, generally they (or whoever is answering their question on StackOverflow) will tell them to look at But I just don't see them at any point in this process going to the readme to say "How do I find the supported versions?" Just my $0.02, no problem if you disagree and prefer to solve differently, I'm a drive-by contributor, not a maintainer here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it then! Always happy to find an agreement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the last 3 years I've never seen someone use this table.
Thanks @jeffwidman and @chrysle! |
How can you possibly see that? ;-) |
Assumption is based on the number of times I've referred users to this section. |
It's @atugushev. He sees things that are impossible for normal people to see 😁 : |
As noted in #1937, this matrix is out of date now that https://github.com/jazzband/pip-tools/releases/tag/7.0.0 has shipped.
Technically it could be kept around and add some more rows, but I don't think it's worth the effort... it will always be going out of date. Instead, let the internal dep constraints and classifiers within
setup.py
/pyproject.toml
constrain what versions ofpython
/pip
are compatible with that version ofpip-tools
. Most users won't care, but those who will can access that data manually. And otherwise it'll all be smoothly resolved by package managers.So let's just remove it altogether.
Fix: #1937
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.