Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment marker support in pip-sync #600

Merged
merged 2 commits into from
Nov 16, 2017
Merged

Fix environment marker support in pip-sync #600

merged 2 commits into from
Nov 16, 2017

Conversation

hazmat345
Copy link
Contributor

@hazmat345 hazmat345 commented Nov 16, 2017 •
edited by tysonclugg
Loading

This hopefully fixes the remaining part of #206 - adding support for environment markers in pip-sync.

Contributor checklist
  • Provided the tests for the changes
  • Added the changes to CHANGELOG.md
  • Requested (or received) a review from another contributor

vphilippon
vphilippon approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vphilippon vphilippon added this to the 1.10.2 milestone Nov 16, 2017
@vphilippon
Copy link
Member

Thanks for the PR 👍

@vphilippon vphilippon merged commit 52113ad into jazzband:master Nov 16, 2017
@vphilippon vphilippon mentioned this pull request Nov 22, 2017
Closed
This was referenced Nov 22, 2017
Closed
Merged
Open
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
This was referenced Nov 30, 2017
Closed
Closed
Closed
Merged
Closed
@pyup-bot pyup-bot mentioned this pull request Dec 1, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
@pyup-bot pyup-bot mentioned this pull request Feb 1, 2018
Closed
@pyup-bot pyup-bot mentioned this pull request Feb 12, 2018
Closed
@pyup-bot pyup-bot mentioned this pull request Mar 1, 2018
Closed
@AndydeCleyre AndydeCleyre mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vphilippon vphilippon vphilippon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hazmat345 @vphilippon