Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite absolute path as relative to the destination requirements.txt file #673

Closed
wants to merge 8 commits into from

Conversation

maciej-gol
Copy link

@maciej-gol maciej-gol commented Aug 8, 2018

This is a fix to a pull request made by @orf . This time, it resolves absolute path relative to the destination requirements file, making it work regardless you call pip-compile as long as you don't move the destination file around.

Changelog-friendly one-liner: Rewrite absolute path as relative to the destination requirements.txt file

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

@maciej-gol
Copy link
Author

Adding the co-author @AmiroNasr to the conversation.

@maciej-gol
Copy link
Author

Tests are failing because of broken newest pip integration.

@ztane
Copy link

ztane commented Sep 12, 2018

Waiting for this...!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality needs rebase Need to rebase or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants