Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --find-links in pip-compile output #793

Merged
merged 1 commit into from
May 2, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Apr 22, 2019

This adds support to pip-compile for the -f, --find-links flag in the input requirements.in. Rebased #704 and adjusted tests. Thanks @estan for the contribution!

Changelog-friendly one-liner: Add support for --find-links in pip-compile output.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev changed the title Add support for --find-links in compile input Add support for --find-links in pip-compile output Apr 22, 2019
@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #793 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   98.06%   98.07%   +<.01%     
==========================================
  Files          34       34              
  Lines        1962     1972      +10     
  Branches      256      257       +1     
==========================================
+ Hits         1924     1934      +10     
  Misses         26       26              
  Partials       12       12
Impacted Files Coverage Δ
tests/test_writer.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️
piptools/writer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0a91a...6646019. Read the comment docs.

@atugushev atugushev requested a review from blueyed April 22, 2019 07:40
@suutari
Copy link
Contributor

suutari commented Apr 22, 2019

FYI, I've implemented something similar in #453 over a year ago. Though with the difference that only relative directories are written out, since absolute ones rarely make sense to be stored into the txt file. If this gets merged, then #453 can be closed (or the other way around).

@atugushev
Copy link
Member Author

Hello @suutari,

Thank you for pointing that out! I agree there should be relative links. I'll port your code here if you don't mind.

@atugushev
Copy link
Member Author

atugushev commented Apr 22, 2019

@suutari

Though with the difference that only relative directories are written out

I've found an interesting FIXME comment in pip source code:

# FIXME: it would be nice to keep track of the source
# of the find_links: support a find-links local path
# relative to a requirements file.

Maybe it's better to fix this case on the pip side instead of hard coding it in the pip-tools?

@atugushev atugushev added the enhancement Improvements to functionality label Apr 24, 2019
@auvipy auvipy added this to the 3.7.0 milestone May 2, 2019
@auvipy auvipy merged commit b14de39 into jazzband:master May 2, 2019
@estan
Copy link
Contributor

estan commented May 18, 2019

@atugushev I've been completely swamped and almost forgot about my PR. Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants