Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #833

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Conversation

adamchainz
Copy link
Contributor

Changelog-friendly one-liner: n/a

Contributor checklist
  • [n/a] Provided the tests for the changes.
  • [n/a] Requested a review from another contributor.
  • [n/a] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • [n/a] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@adamchainz
Copy link
Contributor Author

@atugushev would you mind checking this over? :)

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Have a couple suggestions though.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@atugushev atugushev added the docs Documentation related label Jun 6, 2019
* Move and duplicate note about running under multiple Python versions to the start of each command's section.
* Add note about using `--upgrade` and `--upgrade-package` together following jazzband#831.
* Document `--output-file`.
@atugushev atugushev merged commit 7824d94 into jazzband:master Jun 7, 2019
@adamchainz adamchainz deleted the documentation branch June 7, 2019 07:49
@adamchainz
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants