Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip>=19.2 compatibility #857

Merged
merged 5 commits into from
Jul 25, 2019
Merged

Fix pip>=19.2 compatibility #857

merged 5 commits into from
Jul 25, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jul 23, 2019

Closes #856.

TODO

Changelog-friendly one-liner: Fix pip>=19.2 compatibility

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Refs #853.

@codecov

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #857 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #857     +/-   ##
=========================================
+ Coverage   98.85%   99.06%   +0.2%     
=========================================
  Files          36       35      -1     
  Lines        2191     2147     -44     
  Branches      285      284      -1     
=========================================
- Hits         2166     2127     -39     
+ Misses         15       12      -3     
+ Partials       10        8      -2
Impacted Files Coverage Δ
piptools/repositories/local.py 91.11% <100%> (+0.41%) ⬆️
piptools/utils.py 100% <100%> (ø) ⬆️
tests/test_repositories.py 100% <100%> (ø) ⬆️
tests/test_top_level_editable.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️
tests/test_repository_pypi.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/repositories/pypi.py 95.23% <100%> (+2.6%) ⬆️
tests/test_repository_local.py 100% <100%> (ø) ⬆️
tests/conftest.py 97.36% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a116c7...072e72b. Read the comment docs.

@atugushev atugushev added this to the 3.9.1 milestone Jul 24, 2019
@atugushev atugushev force-pushed the pip-19.2 branch 2 times, most recently from 0f65f7d to ffeb284 Compare July 24, 2019 12:02
@atugushev atugushev modified the milestones: 3.9.1, 3.10.0 Jul 24, 2019
Fix coverage decreasing
Turns out Command._build_package_finder avaiable since 8.1.1
@atugushev atugushev changed the title [WIP] Fix pip>=19.2 compatibility Fix pip>=19.2 compatibility Jul 24, 2019
@atugushev
Copy link
Member Author

Finally it's all green!

@vphilippon @blueyed kindly ping you guys, review it please if you have a time.

piptools/repositories/pypi.py Outdated Show resolved Hide resolved
piptools/repositories/pypi.py Outdated Show resolved Hide resolved
@atugushev atugushev modified the milestones: 3.10.0, 4.0.0 Jul 24, 2019
Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not looked too closely, but given that CI will like it I think it's good!
Thanks!

@atugushev
Copy link
Member Author

Thanks @auvipy @blueyed !

@atugushev atugushev merged commit aaa4abf into jazzband:master Jul 25, 2019
@atugushev atugushev deleted the pip-19.2 branch July 25, 2019 20:54
@atugushev
Copy link
Member Author

pip-tools v4.0.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile broken with pip 19.2
3 participants