Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parse extras_require when compile setup.py #877

Closed
wants to merge 2 commits into from

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Aug 20, 2019

Closes #625.

Changelog-friendly one-liner: Parse extras_require when compile setup.py file.

TODO

  • handle extras_require={'dev': "small-fake-a==0.1"}
  • research how pip handles extras_require via pip install -e .[dev]
Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the enhancement Improvements to functionality label Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #877 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   99.05%   99.06%   +0.01%     
==========================================
  Files          35       35              
  Lines        2231     2256      +25     
  Branches      285      290       +5     
==========================================
+ Hits         2210     2235      +25     
  Misses         13       13              
  Partials        8        8
Impacted Files Coverage Δ
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfa887...6875c10. Read the comment docs.

@atugushev atugushev force-pushed the fix-issue-625 branch 2 times, most recently from 91d81b5 to 78a1c13 Compare August 20, 2019 08:57
Since setuptools>=36.2.1 environment markers (PEP496) has proper support.
@atugushev atugushev changed the title Parse extras_require when compile setup.py [WIP] Parse extras_require when compile setup.py Aug 20, 2019
@atugushev atugushev added the needs rebase Need to rebase or merge label Sep 26, 2019
@atugushev
Copy link
Member Author

I'll close it in favor of #908.

@atugushev atugushev closed this Oct 4, 2019
@atugushev atugushev deleted the fix-issue-625 branch January 26, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality needs rebase Need to rebase or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip-compile ignores extras_require when parsing setup.py
2 participants