-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show progress bar when downloading package in verbose mode #949
Conversation
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
=======================================
Coverage 99.44% 99.45%
=======================================
Files 36 36
Lines 2540 2554 +14
Branches 312 314 +2
=======================================
+ Hits 2526 2540 +14
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
5f837d3
to
b514d21
Compare
It looks good! I just want to note, in case this is surprising or not desirable: If run with stderr in foreground and stdout directed to a file, the progress bar is not shown. |
Thanks for review @AndydeCleyre! It seems |
I think we could fix that by patching:
I also discovered that hashing progress bar prints to stdout (addressed in #1113), could be fixed with pip-tools/piptools/repositories/pypi.py Line 286 in 7a52ce8
|
7485885
to
5cecccf
Compare
Fixed in 5cecccf6085ef11c35e6217a829652b4496a768e. Could you take a look please? |
LGTM 👍 And thanks for adding the logging comments, especially the difference between pip log level and pip-tools'. |
5cecccf
to
a28047f
Compare
a28047f
to
31fe23c
Compare
Byt the way, this PR would also help with investigating such issues like #1116 by |
Thank you so much for the feedback @AndydeCleyre! |
Resolves #832.
Demonstration:
Changelog-friendly one-liner: Show progress bar when downloading package in a verbose mode of
pip-compile
.Contributor checklist