-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --no-deps flag to pip-sync, which is simply passed through to pip install #987
Conversation
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 99.11% 99.11% +<.01%
==========================================
Files 34 34
Lines 2360 2363 +3
Branches 302 303 +1
==========================================
+ Hits 2339 2342 +3
Misses 11 11
Partials 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks, @AndydeCleyre!
Just wondering, why do you prefer to mark tasks this way:
instead of
wich is the current Github's markdown syntax? See the doc. With the first one we get this progress bar on PRs list (note the progress-bar): The second one marks tasks correctly (note the progress-bar): |
Just because I never read those docs, and generally think of a check as "yes" and an |
There is an issue #321 the implementation of which can supersede this PR. Let me know what you think of it. |
@atugushev If |
… install when given; Add --no-deps pass-through to test_pip_install_flags
e6f3607
to
b0fafe0
Compare
Close this in favor of #1080. |
--no-deps
can now be provided topip-sync
, whereby--no-deps
will be passed through topip install
, and un-locked deps of locked requirements will be either removed or not installed in the first place, in order to match the lockfile exactly, despite breaking package dependencies.Changelog-friendly one-liner:
pip-sync
now accepts--no-deps
, to match lockedtxt
s exactly, ignoring any unlocked dependenciesContributor checklist