Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: recursively pull in other environment variables #1

Closed
jazzdelightsme opened this issue Aug 11, 2023 · 2 comments
Closed

Feature: recursively pull in other environment variables #1

jazzdelightsme opened this issue Aug 11, 2023 · 2 comments

Comments

@jazzdelightsme
Copy link
Owner

See this Issue in the winget-cli repo: microsoft/winget-cli#3077

WingetPathUpdater did not help for that package. The reason was that PATH was updated to add the following strings:

%NVM_HOME%
%NVM_SYMLINK%

So although WingetPathUpdater's wrapper scripts properly updated PATH, it did NOT bring in NVM_HOME et al. Would be nice to handle that.
@jazzdelightsme
Copy link
Owner Author

What about other environment variables, not directly referenced by PATH, but still important (perhaps crucial) to program operation? So maybe we should just diff the entire block...

This was referenced Aug 11, 2023
Merged
Merged
jazzdelightsme added a commit that referenced this issue Aug 13, 2023
@jazzdelightsme
Update ALL environment variables (#2)
60f73c1 
It turns out that one way that some apps update the PATH environment variable is to add other (unexpanded) environment variables. And ... there could be other important variables that get added (like VIMRUNTIME, perhaps). So... let's just update ALL environment variables.

Addresses #1
@jazzdelightsme
Copy link
Owner Author

Now fixed and release in v1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jazzdelightsme