-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to generate relative image links in output #440
Comments
Thanks for raising this issue. With 2.6.0, the image URL generation has changed (you may have already seen this). This change skips the images where URL explicitly starts with http:// or https://. I think the initial version of change also excluded modifying image URLs starting with Were you able to achieve all this with 2.5.1 where image path's are not modified? Running in server mode could be used while testing site in local. |
I don't think that will help. For example if the file is in
I don't remember what was happening with 2.5.1 (I either wasn't having a problem or links were to existing images that were already on the
Gradle plugin doesn't support server mode: jbake-org/jbake-gradle-plugin#32 |
@msgilligan see my comment on how to use gretty plugin with gradle to serve a baked site. For testing, staging, production scenario have a look at my website project on how to work with different environments https://github.com/ancho/calmdev-website/blob/master/gradle/environment.gradle Hope that helps a bit. |
Thanks @ancho, I may try that. |
How hard would this be to fix? Is it something that could be easily submitted as a PR? |
@jonbullock It seems to me a static site generator should be able to generate fully static sites that:
Any suggestions on what we can do got get his fixed? I'm willing to help if given some guidance and this is not too difficult. |
fixes jbake-org#455 and jbake-org#440
Haven't reviewed the changes in #459 properly yet but @manikmagar comment on #455 sounds like it would address this issue too. I'll review it ASAP and look to get it out in a 2.6.2 release. |
fixes jbake-org#455 and jbake-org#440
fixes jbake-org#455 and jbake-org#440
I want to generate an output site file tree that has relative links to the images. I don't want to use server mode -- I want an accurate preview loading from
file://
URLs. I also want the option to post to a staging and production server (using Gitlab CI) so the image links shouldn't be hardcoded to the production server.But the images are pulled from the previously published version of the site running on
site.host
.According to the documentation
site.host
should contain the URL of the server and is overridden for server mode. But there appears to be no (easy) way to request the generation of relative image links in the output.I'm in the process of updating to JBake 2.6.0.
Note jbake-org/jbake-gradle-plugin#32 -- Gradle plugin doesn't support server mode.
The text was updated successfully, but these errors were encountered: