-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Limit number of header lines #516
base: master
Are you sure you want to change the base?
Conversation
3dd2448
to
194f127
Compare
…lank lines, test against a regex; do not require status and type if defaults are set.
194f127
to
ce2f8a7
Compare
Rebased, not ready - need to compare with the current hasHeader(). |
ce2f8a7
to
462023f
Compare
Getting this, does it ring a bell?
Looks like it runs with Groovy 2.4 for some reason. |
Yes it does....https://issues.apache.org/jira/browse/GROOVY-8844 Are you really sure it uses groovy 2.4? How do you come to this conclusion? When does the error occur? While running test or smokeTest? I got that error in the smokeTests and fixed the template of the groovy-mte example project. Try |
No I'm not sure about Groovy 2.4, I deduced from the error which looks like there's a property missing that is new in 2.5. Occurs during a build. Graddle jar IIRC. Will try again later this week. |
Looks like it was resolve by the clean. |
@OndraZizka is this PR still WIP? |
Without any limit, JBake may encounter files that are very long, and try parsing them as text, looking for a header for the whole size of the file.
Looking for a header should be stopped after certain amount of lines and bytes.