Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/option improvements #615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

toolforger
Copy link

Not 100% sure if this meets project standards, just let me know what needs to be done and what can be improved.

Follow principle of least surprise: People expect --version to exist.
Follow principle of least output: Nothing on stdout except if requested.
(Dealing with the INFO output is for another PR.)

Compare e.g. perl, python.

* Have -V and --version (avoid -v, it is usually --verbose)
* Do not print version string to stdout for --help, nor on startup
* Log the version string at INFO level during non --help startup

No testing for --version/-V, there is no logic to test (just a getter)
@toolforger
Copy link
Author

The failure looks like an old JVM trying to load a newer-format class file.

@jonbullock jonbullock added this to the v2.7.0 milestone May 9, 2021
@ancho ancho mentioned this pull request May 12, 2021
@jonbullock jonbullock modified the milestones: v2.7.0, v2.8.0 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants