Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OrientDB 3.1.16 to support Apple Silicon #755

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Mar 14, 2022

@kwin
Copy link
Contributor Author

kwin commented Mar 14, 2022

I experience local test failures both in latest master and in this PR, so not sure this introduces regressions.

@kwin kwin force-pushed the bugfix/apple-silicon-support-with-orientdb-3.1.16 branch from 5235d9e to 7cb4e24 Compare March 14, 2022 15:25
@jbaron
Copy link

jbaron commented Aug 16, 2022

Have same problem (see error below), but not a problem if I just upgrade the version at runtime (see also my comment at #709)

com.orientechnologies.orient.core.exception.ODatabaseException: Invalid database name:'/var/folders/sn/pw3sb44d14g1g3_t1xh4_qlr0000gn/T/junit16331792743401417938/documents1660680832696'
            at app//com.orientechnologies.orient.core.db.OrientDBEmbedded.checkDatabaseName(OrientDBEmbedded.java:1113)
            at app//com.orientechnologies.orient.core.db.OrientDBEmbedded.create(OrientDBEmbedded.java:613)
            at app//com.orientechnologies.orient.core.db.OrientDB.createIfNotExists(OrientDB.java:269)
            at app//com.orientechnologies.orient.core.db.OrientDB.createIfNotExists(OrientDB.java:256)
            at app//org.jbake.app.ContentStore.startup(ContentStore.java:95)

@kwin
Copy link
Contributor Author

kwin commented Sep 18, 2022

Superseded by #765.

@kwin kwin closed this Sep 18, 2022
@jonbullock
Copy link
Member

@jbaron The tests use a path as the DB name and OrientDB v3.1.x has an issue with the slashes, which v3.0.x didn't. This isn't a problem in 99% of real life scenarios where the DB name will most likely be "cache". While the upgrade to v3.1.x is pretty seamless it does require a change to JBake relating to the retrieval of tags.

Thanks @kwin for looking into this and raising the PR in the first place.

@jonbullock jonbullock added this to the v2.7.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants