Migrate neli-proc-macros to syn 2.0.x #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transition to syn 2.x involved addressing several breaking changes from syn 1.x. Some of these changes were straightforward, such as the replacement of Tokens Add with Plus, Colon2 with PathSep, and the renaming of LifeTimeDef struct to LifeTimeParam. However, some changes required modifications to our structures. For instance, we now retrieve .meta from an Attribute instead of using .parse_meta(). Additionally, Paths now support .is_ident(), which simplifies their comparison. The removal of NestedMeta necessitated a new approach to parsing nested elements from Paths using TokenTree tokens. These tokens can be Groups, Idents, Puncts, or Literals, enabling us to determine their purpose.
|
Hello, next week works well for me if there are any tweaks needed on this code. Just please let me know if anything comes up! |
|
Hi @duMagnus, I'm currently reviewing this PR and will have a few comments to post a little bit later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transition to syn 2.x involved addressing several breaking changes from syn 1.x. Some of these changes were straightforward, such as the replacement of Tokens Add with Plus, Colon2 with PathSep, and the renaming of LifeTimeDef struct to LifeTimeParam. However, some changes required modifications to our structures. For instance, we now retrieve .meta from an Attribute instead of using .parse_meta(). Additionally, Paths now support .is_ident(), which simplifies their comparison.
The removal of NestedMeta necessitated a new approach to parsing nested elements from Paths using TokenTree tokens. These tokens can be Groups, Idents, Puncts, or Literals, enabling us to determine their purpose.