[IMP] stock_release_channel_shipment_advice_deliver: Be more lax on backorder pickings / improve move to unrelease retrieval #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option auto_delivery and allow to print in-process shipment advice
Allow to deliver when the picking is partially processed but no backorder is created
Fix test as channels are now created by default in state asleep
Name the tests
Allow to print shipment in delivered state
- Show button 'Deliver' in the kanban view - Show button 'Plan Shipment' if not auto deliver - Update state of release channel to 'delivering' when the related shipment advice starts
…shipment_advice_deliver-3 [16.0][IMP] stock_release_channel_shipment_advice_deliver
…shipment_advice_deliver-4 [16.0][REF] stock_release_channel_shipment_advice_deliver: Update test
…ackorder pickings Don't raise error if an unstarted backorder still remains in the chain
… with a picking backorder As we want to let the operator deliver even if a backorder still exists, show the confirmation wizard in that case (and not an error).
|
Includes also : #9 |
rousseldenis
changed the title
…l picking_ids field To get the stock moves to unrelease, don't rely on release channel's picking_ids field as this is raising infinetely with time. Do a search instead.
rousseldenis
force-pushed
the
16.0-imp-deliver-check-progress-dro
branch
2 times, most recently
from
97ee1b9
to
5bcd8db
Compare
|
I needed to remove test-requirements as I had conflicts merging all branches locally |
jbaudoux
reviewed
Aug 26, 2024
stock_release_channel_shipment_advice_deliver/models/stock_release_channel.py
Outdated
Show resolved
Hide resolved
jbaudoux
reviewed
Aug 26, 2024
stock_release_channel_shipment_advice_deliver/models/stock_release_channel.py
Show resolved
Hide resolved
…unrelease at deliver Add the stock rule option to filter moves to unrelease at deliver
jbaudoux
reviewed
Aug 26, 2024
stock_release_channel_shipment_advice_deliver/models/stock_release_channel.py
Outdated
Show resolved
Hide resolved
…ted pickings twice
rousseldenis
force-pushed
the
16.0-imp-deliver-check-progress-dro
branch
2 times, most recently
from
33790a6
to
7d773df
Compare
jbaudoux
reviewed
Aug 26, 2024
| @@ -136,23 +119,42 @@ def _picking_moves_to_unrelease(self): | |||
| ] | |||
| ) | |||
|
|
|||
| def _shipping_moves_to_unrelease(self): | |||
| moves = self.picking_ids.move_ids.filtered( | |||
There was a problem hiding this comment.
I think if you define open_picking_ids like picking_ids but with a domain (state not in done, cancel) on the field, the orm will apply the domain in the where clause and it will not grow
Then you could replace this just by
moves = self.open_picking_ids._is_unreleaseable()
I think it is better than your at_deliver_to_unrelease_shipping_move_ids which repeats _is_unreleaseable definition
There was a problem hiding this comment.
Yes. I wanted to limit some modifications to the code here defined. That open_picking_ids field should be done in stock_release_channel module. Will do it in a second phase.
There was a problem hiding this comment.
Done here:
|
@jbaudoux In production for weeks |
jbaudoux
force-pushed
the
16.0-release_channel_deliver
branch
from
d4897b0
to
e2b5db6
Compare
jbaudoux
force-pushed
the
16.0-release_channel_deliver
branch
2 times, most recently
from
ca339dc
to
2f028de
Compare
|
I cherry-picked the commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't raise error if an unstarted backorder still remains in the chain