[16.0][IMP] stock_release_channel_shipment_advice_deliver: Add option auto_delivery and allow to print in-process shipment advice #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
reviewed
Mar 29, 2024
| @@ -40,6 +40,7 @@ class StockReleaseChannel(models.Model): | |||
| in_process_shipment_advice_ids = fields.One2many( | |||
| "shipment.advice", compute="_compute_in_process_shipment_advice_ids" | |||
| ) | |||
| auto_deliver = fields.Boolean() | |||
There was a problem hiding this comment.
Can you add as a condition in _compute_is_action_deliver_allowed ?
tuantrantg
force-pushed
the
16.0-imp-stock_release_channel_shipment_advice_deliver
branch
from
7936766
to
7cbc5b9
Compare
tuantrantg
commented
Apr 1, 2024
| @@ -63,6 +64,7 @@ def _compute_is_action_deliver_allowed(self): | |||
| ) | |||
| and bool(rec.picking_to_plan_ids) | |||
| and rec.shipment_planning_method != "none" | |||
| and rec.auto_deliver | |||
There was a problem hiding this comment.
hi @jbaudoux auto_deliver is added in _compute_is_action_deliver_allowed, please review it
…delivery and allow to print in-process shipment advice
tuantrantg
force-pushed
the
16.0-imp-stock_release_channel_shipment_advice_deliver
branch
from
7cbc5b9
to
eae0e05
Compare
|
hi @jbaudoux could you please review it again |
jbaudoux
approved these changes
Apr 3, 2024
jbaudoux
merged commit 39477e3
into
jbaudoux:16.0-release_channel_deliver
1 of 4 checks passed
|
Merging as failing test does not seem related to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.