Add clang-tidy checks #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 455 455
=========================================
Hits 455 455 ☔ View full report in Codecov by Sentry. |
|
Will this apply fixes and recommit? Presumably, it will just fail and we need to fix it manually? If so perhaps we should also add the pre-commit bindings? |
|
This needs a newer version of CMake. Will pick this up again later. It's a distraction for now. |
|
Just pre-commit is probably more useful. I'll set a local helper script up
first
…On Sun, 19 Nov 2023 at 13:25, Antony Peacock ***@***.***> wrote:
Will this apply fixes and recommit? Presumably, it will just fail and we
need to fix it manually? If so perhaps we should also add the pre-commit
bindings?
—
Reply to this email directly, view it on GitHub
<#263 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF5ZE4Q5XNJ42QM6R2ZDRDYFICEXAVCNFSM6AAAAAA7RXUJXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHA2TKMRRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.