Add Denarius Domain TLDs #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
reviewed
Feb 5, 2021
There was a problem hiding this comment.
Given that we already accepted ENS and UnstoppableDomains, this should be fine as a temporary fix, but constantly adding TLDs to the list is not sustainable long term:
- We want to remove use of
go-is-domainTLD safelist from IPFS stack and make go-ipfs accept any string that is a valid DNS hostname- Being RFC compliant should be the only check.
- This way we won't be forcing users to follow what ICANN decides is a "Real TLD".
- We also need to make DNS resolver configurable per TLD, to enable folks from decentralized space to experiment without the need of changing anything in go-ipfs.
- Things should work for any name, as long DNS resolver returns a valid DNSLink (DNS TXT record)
FYSA I started ipfs/kubo#7902 to remove go-ipfs' dependency on this lib (cc @autonome @aschmahmann)
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 5, 2021
- removes reliance on TLD safelist from jbenet/go-is-domain as noted in jbenet/go-is-domain#16 (comment) jbenet/go-is-domain#19 (review) - switch DNSLink checks to `net.isDomainName` which only cares about name being compliant with RFC 1035, RFC 3696, and is not concerned if TLD was blessed by ICANN or some other authority
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of Denarius TLDs
Denarius (D) - https://denarius.io
This PR adds the addition of all of the new upcoming Denarius Domain Name TLDs:
This go module is required for go-ipfs for IPFS to be able to resolve and handle Denarius Domains.