visualstudio2017: if VS Installer needs upgrade, --wait does not work #7

jberezanski · 2017-04-19T20:39:01Z

When installing a new VS 2017 product package, if the VS Installer already exists on the machine but needs to be upgraded, the VS setup bootstrapper will invoke the upgrade process but will exit before the upgraded installer finishes, even invoked with --wait.

Until the VS setup bootstrapper is fixed, the install logic should probably look for additional VS installer processes spawned during the installation and wait for all of them to finish.

- skip VS 2017 product installation if the product is already installed (prevents upgrade, but also avoids problems with upgrade, such as broken VS Installer or installation still running after Chocolatey exits) (#7, #8) - warn the user to disallow running the Chocolatey Auto Uninstaller (#6)

jberezanski · 2017-08-30T20:59:43Z

https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio

--noUpdateInstaller
New in 15.2, optional: If present, prevents the installer from updating itself when quiet is specified. The installer will fail the command and return a non-zero exit code if noUpdateInstaller is specified with quiet when an installer update is required.

…ch operation GitHub-Issue: GH-7 GH-8 GH-26

… use detected instance info for installer update GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…stance, if present GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…cted VS instances GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…channel manifest - refactor to facilitate reuse - support obtaining the file from layout GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…quired GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…rrect Installer version detection logic GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…out of Get-VSChannelManifestItemUrl GitHub-Issue: GH-7 GH-8 GH-10 GH-26

… report setup engine version GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…r to check engine version GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…perate on existing manifest GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…determination logic Logic extrapolated from Microsoft.VisualStudio.Setup.dll/Microsoft.VisualStudio.Setup.ChannelManager.EnsureEngineCanReadManifests(). EngineVersion := FileVersion of <VS Installer>\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\Microsoft.VisualStudio.Setup.dll EngineVersion is in catalog manifest ($manifest.engineVersion) installer version := resources\app\main\Main.js: var EXE_VERSION = require("../package.json").version; function createSetupEngineAdapter: // exeVersionForEngine is used to detect updates. During development, // checking for updates is undesired. Typically, a true release version // looks like "x.y.build.qfe", otherwise the version is "x.y.z". // Passing null for version skips checking for updates. var exeVersionParts = EXE_VERSION.split("."); var exeVersionForEngine = exeVersionParts.length > 3 ? EXE_VERSION : null; (this gets passed to Microsoft.VisualStudio.Setup.Service.dll/Microsoft.VisualStudio.Setup.ProductsProviderService.Initialize() and from that through ((Service)base).Initialize() -> Service.InitializeSharedFields() to ChannelManagerFactory and ChannelManager) so: <VS Installer>\resources\app\package.json -> version NOT <VS Installer>\vs_installer.version.json -> version! installer version is in channel manifest ($bootstrapper.version) ChannelManager.EnsureEngineCanReadManifests() compares engine versions and installer versions; both comparisons must be satisfied (greater or equal) GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…load a stale cached file GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…talling a new VS product GitHub-Issue: GH-7 GH-8 GH-26

…sent GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…ut, if present GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…wnload, if known GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…lled product When determining the channel uri using data obtained from an installed product instance, InstallChannelUri should take precedence over ChannelUri. GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…g product update ChannelUri should be used for updates. InstallChannelUri can be used for adding components/workloads. GitHub-Issue: GH-7 GH-8 GH-10 GH-26

- if download fails after the local file is created (on the hash check, for example), remove the downloaded file - give the local files a bit more descriptive names for easier troubleshooting GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…uring download, if known" The checksum and size of the component manifest in the channel manifest seem totally bogus. This reverts commit f8de214. GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…cksum is not used GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…e from layout path only if --noWeb was requested If --noWeb is not specified, the VS installer/bootstrapper will still look to the online manifests even if invoked from layout. The extension needs to do that, too. GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…ller update only if --noWeb was requested Without --noWeb, the VS Installer will use ChannelUri, so the extension needs to to that, too. GitHub-Issue: GH-7 GH-8 GH-10 GH-26

This may be useful when instaling a fresh instance of a VS product using a bootstrapper which installs a specific version of the product (e.g. the 15.0 bootstrappers available from MSDN). Note that because the 15.0 bootstrapper does not support --noUpdateInstaller, the package must be instructed not to pass this parameter to the bootstrapper, by additionally specifying --no-noUpdateInstaller. GitHub-Issue: GH-7 GH-8 GH-10 GH-26

…e of the bootstrapper Due to the way the VS Installer update feature of the VS setup bootstrapper (--update) is implemented, --update must be the last argument, otherwise the bootstrapper will assume it is in "roundtrip update" mode and will start the VS Installer once it is updated. The problem is that recent versions of the parent ("box") application (vs_<product>.exe) started appending an additional argument (--env) to the VS setup bootstrapper invocation, effectively breaking the --update feature. To add insult to injury, the --env argument is not used during the VS installer update. Fortunately, the box application is just a flavor of a self-extracting zip archive and can be unzipped using standard zip tools. So, the workaround is to unzip the box application and invoke the extracted VS setup bootstrapper, taking care to pass arguments in correct order. GitHub-Issue: GH-7 GH-8 GH-26

…aller upon --noUpdateInstaller GitHub-Issue: GH-7 GH-8 GH-26

…ainting the original package parameters GitHub-Issue: GH-7 GH-8 GH-26

…per ignoring --wait in some cases Related to: GH-7 GH-97

jberezanski mentioned this issue May 18, 2017

vs2017 webbuildtools: installation still running in the background after Choco reports successfull install #13

Open

jberezanski mentioned this issue Oct 6, 2017

visualstudio2017: defend against Chocolatey AutoUninstaller #6

Closed

jberezanski mentioned this issue Nov 12, 2017

Add .NET Core build tools workload package #23

Closed

jberezanski mentioned this issue Apr 28, 2018

chore(BuildTools): Update version to enable updates #36

Closed

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: update VS 2017 installer before ea…

4b69ef8

…ch operation GitHub-Issue: GH-7 GH-8 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: Start-VisualStudioModifyOperation:…

32bee83

… use detected instance info for installer update GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: use channelUri from detected VS in…

1eb4c2c

…stance, if present GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: obtain InstallChannelUri from dete…

3f6250c

…cted VS instances GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: refactor and improve obtaining of …

9e26b9f

…channel manifest - refactor to facilitate reuse - support obtaining the file from layout GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: update the VS Installer only if re…

9f1baad

…quired GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: document findings regarding the co…

a26823a

…rrect Installer version detection logic GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: extract Get-VSChannelManifestItem …

d0b1e41

…out of Get-VSChannelManifestItemUrl GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: teach Get-VisualStudioInstaller to…

6819ba7

… report setup engine version GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: teach Install-VisualStudioInstalle…

bb77968

…r to check engine version GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: teach Get-VSComponentManifest to o…

b3cbede

…perate on existing manifest GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: make Get-ChocolateyWebFile re-down…

611354c

…load a stale cached file GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: update the VS installer before ins…

9129b4b

…talling a new VS product GitHub-Issue: GH-7 GH-8 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: read manifests from layout, if pre…

c84ad06

…sent GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: install the VS Installer from layo…

be34835

…ut, if present GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: verify manifest checksum during do…

f11a149

…wnload, if known GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: explain why component manifest che…

c42de80

…cksum is not used GitHub-Issue: GH-7 GH-8 GH-10 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: _really_ skip updating the VS Inst…

085d6f2

…aller upon --noUpdateInstaller GitHub-Issue: GH-7 GH-8 GH-26

jberezanski added a commit that referenced this issue May 15, 2018

chocolatey-visualstudio.extension: prevent Install-VSInstaller from t…

0a62b30

…ainting the original package parameters GitHub-Issue: GH-7 GH-8 GH-26

jberezanski mentioned this issue Mar 13, 2021

Choco install visualstudio2017-workload-vctools no longer works on windows-2019 #97

Open

jberezanski added a commit that referenced this issue Mar 13, 2021

chocolatey-visualstudio.extension: update workaround for the boostrap…

da54eea

…per ignoring --wait in some cases Related to: GH-7 GH-97

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

visualstudio2017: if VS Installer needs upgrade, --wait does not work #7

visualstudio2017: if VS Installer needs upgrade, --wait does not work #7

jberezanski commented Apr 19, 2017

jberezanski commented Aug 30, 2017

visualstudio2017: if VS Installer needs upgrade, --wait does not work #7

visualstudio2017: if VS Installer needs upgrade, --wait does not work #7

Comments

jberezanski commented Apr 19, 2017

jberezanski commented Aug 30, 2017