Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to build and release images for s390x #178

Merged
merged 3 commits into from
May 30, 2024

Conversation

namrata-ibm
Copy link
Contributor

Changes included in this PR:

  1. Updated base image to eclipse-temurin:ubi9-minimal considering it supports multiple archs. Also centos 7 will reach its end of life down the line. Wanted to understand whether this change would have any major impact on existing users?
  2. Added s390x to jdk 11 & 17 matrix as jdk 20 is not yet available for s390x.

Resolves #173

@namrata-ibm
Copy link
Contributor Author

@jmesnil could you please share your thoughts?

@namrata-ibm
Copy link
Contributor Author

Can anyone have a look?

Copy link
Contributor

@jmesnil jmesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namrata-ibm sorry for the late reply

I've recently updated WildFly Docker image to produce a JDK21 variant on ubi9-minimal that supports s390x.

Could you update your PR to rebase and add the linux/s390x platform for this JDK version?

I'd prefere to postpone the switch from centos7 to ubi9-minimal after it's communicated to our community with the impeding end of line of CentOS 7.

However, I see no issue with respiring our latest WildFly 32 images to add s390x support to their JDK 21 variants.

@namrata-ibm
Copy link
Contributor Author

@jmesnil Thank you for your comments, will work on changes and update PR.

@namrata-ibm
Copy link
Contributor Author

@jmesnil I have updated PR with your suggestions. Could you please have a look?
Thank you very much for your support.

@namrata-ibm namrata-ibm requested a review from jmesnil May 30, 2024 09:25
@jmesnil jmesnil merged commit fb7e8bc into jboss-dockerfiles:master May 30, 2024
@jmesnil
Copy link
Contributor

jmesnil commented May 30, 2024

@namrata-ibm thanks!

@jmesnil
Copy link
Contributor

jmesnil commented May 31, 2024

@namrata-ibm I've released new image tags with support for s390x: quay.io/wildfly/wildfly:latest-jdk21

Could you please try them to make sure they run as expected? Thanks for you contribution!

@namrata-ibm
Copy link
Contributor Author

Hi @jmesnil I have verified that latest/latest-jdk21 images work as expected on s390x.
Thank you very much for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s390x images
2 participants