-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hidden tag for latest Fuse images #56 #57
Remove hidden tag for latest Fuse images #56 #57
Conversation
it allows to have them listed in catalog component types when using odo Signed-off-by: Aurélien Pupier <[email protected]>
@astefanutti Github is suggesting you as a reviewer. Can you review it please? or redirect to someone else who can review it? |
@apupier we added the |
@kadel Can you provide me your point of contact in OpenShift team with which this "hidden" tag was discussed please? |
@astefanutti do you have some references to discussions that occurred to choose to use "hidden" tag for Fuse image? to see if it is still relevant or not. |
The issue description is incomplete. The point is that the images appearing in the service catalog are confusing for the end-user as they cannot be used as is. So it was decided to hide them so that user can focus on the quickstarts and not get confused with images showing up. |
tried with Fuse Java image and https://github.com/jboss-fuse/fuse-rest-http-booster and it is working fine. I created #59 to help users getting started the first time it is using it and don't know where to find examples. |
It was part of the bigger discussion. @jorgemoralespou might have a little bit more info |
If that works, then it makes sense to have the builder image visible. |
@apupier, for us is fine whatever you do. We just consume the catalog with any non-hidden builders. Just one question out of curiosity, what's the difference between this builder and openjdk builder? I think we should try to converge in one single Java builder if possible, to make things easier for users. |
I don't know the technical differences. I just know that the OpenJDK was created after.
I already proposed to merge them but it was pushed back by Architect and Product Manager. The main problem for now seems to be that the openjdk builder doesn't have an upstream version. You will need to reach them directly if you want it to happen. |
closing as there was no progress for a long time. |
it allows to have them listed in catalog component types when using odo
Signed-off-by: Aurélien Pupier [email protected]