Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden tag for latest Fuse images #56 #57

Conversation

apupier
Copy link
Member

@apupier apupier commented Mar 5, 2019

it allows to have them listed in catalog component types when using odo

Signed-off-by: Aurélien Pupier [email protected]

it allows to have them listed in catalog component types when using odo

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier
Copy link
Member Author

apupier commented Mar 7, 2019

@astefanutti Github is suggesting you as a reviewer. Can you review it please? or redirect to someone else who can review it?

@astefanutti
Copy link
Contributor

astefanutti commented Mar 7, 2019

@apupier we added the hidden tag as the images were showing up in the OpenShift service catalog and it was considered confusing for the end-user. I understand based on your PR that odo relies on the hidden tag too but we have to make sure this is the right semantic and that it is ok to have the image showing up again in the service catalog.

@apupier
Copy link
Member Author

apupier commented Mar 7, 2019

@kadel Can you provide me your point of contact in OpenShift team with which this "hidden" tag was discussed please?
Would like to roundtrip with OpenShift team to know what is the correct solution.

@apupier
Copy link
Member Author

apupier commented Mar 7, 2019

@astefanutti do you have some references to discussions that occurred to choose to use "hidden" tag for Fuse image? to see if it is still relevant or not.

@astefanutti
Copy link
Contributor

@apupier
Copy link
Member Author

apupier commented Mar 7, 2019

@apupier https://issues.jboss.org/browse/ENTESB-8982

The pointed issue is mentioning to have only the Fuse 7 entries with icons instead of having both 6.3 and 7 entries.
So it means that it is only a matter of having an icon for the builders too?
it seems that there is an image in the Catalog when I remove the hidden filter for it (it is the "Red hat Fuse 7 java"):
image

or I am missing something else in the ticket?

@astefanutti
Copy link
Contributor

The issue description is incomplete. The point is that the images appearing in the service catalog are confusing for the end-user as they cannot be used as is. So it was decided to hide them so that user can focus on the quickstarts and not get confused with images showing up.

@apupier
Copy link
Member Author

apupier commented Mar 8, 2019

All other builders are available in the catalog:
image

when clicking on them, there is a wizard to use them, and a "Try sample repository" is provided.
image

I would expect Fuse builder to also support this kind of things. I will try as soon as possible.

@apupier
Copy link
Member Author

apupier commented Mar 8, 2019

tried with Fuse Java image and https://github.com/jboss-fuse/fuse-rest-http-booster and it is working fine. I created #59 to help users getting started the first time it is using it and don't know where to find examples.

@kadel
Copy link

kadel commented Mar 8, 2019

@kadel Can you provide me your point of contact in OpenShift team with which this "hidden" tag was discussed please?
Would like to roundtrip with OpenShift team to know what is the correct solution.

It was part of the bigger discussion.

@jorgemoralespou might have a little bit more info

@astefanutti
Copy link
Contributor

tried with Fuse Java image and https://github.com/jboss-fuse/fuse-rest-http-booster and it is working fine. I created #59 to help users getting started the first time it is using it and don't know where to find examples.

If that works, then it makes sense to have the builder image visible.

@jorgemoralespou
Copy link

@apupier, for us is fine whatever you do. We just consume the catalog with any non-hidden builders.

Just one question out of curiosity, what's the difference between this builder and openjdk builder? I think we should try to converge in one single Java builder if possible, to make things easier for users.

@apupier
Copy link
Member Author

apupier commented Mar 11, 2019

Just one question out of curiosity, what's the difference between this builder and openjdk builder?

I don't know the technical differences. I just know that the OpenJDK was created after.

I think we should try to converge in one single Java builder if possible, to make things easier for users.

I already proposed to merge them but it was pushed back by Architect and Product Manager. The main problem for now seems to be that the openjdk builder doesn't have an upstream version. You will need to reach them directly if you want it to happen.

@apupier
Copy link
Member Author

apupier commented May 6, 2020

closing as there was no progress for a long time.

@apupier apupier closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants