Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven-ear-plugin from 3.0.1 to 3.3.0 #147

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2022

Bumps maven-ear-plugin from 3.0.1 to 3.3.0.

Commits
  • 340c7ac [maven-release-plugin] prepare release maven-ear-plugin-3.3.0
  • bdff9e6 Prepare next release - bump project version, add simple change log
  • 1f946a7 [MEAR-321] Remove not implemented parameter - useBaseVersion
  • 3f5df0e Refresh download page
  • 07a8498 [MEAR-298] Improving EAR packaging use FileSystem instead of repackaging
  • f338c9d Remove unused parameter
  • cd033ab [MEAR-301] fix repackaging when defaultLibBundleDir beginning with dot
  • 39b8e0f [MEAR-304] Update dependencies used in IT tests
  • abe255d Bump plexus-utils from 3.3.0 to 3.4.2
  • 262412d [MEAR-319] Remove generated MANIFEST from outdatedResources
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [maven-ear-plugin](https://github.com/apache/maven-ear-plugin) from 3.0.1 to 3.3.0.
- [Release notes](https://github.com/apache/maven-ear-plugin/releases)
- [Commits](apache/maven-ear-plugin@maven-ear-plugin-3.0.1...maven-ear-plugin-3.3.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-ear-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 24, 2022
Copy link
Contributor

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me repaste my original comment on #131 (review) here too:

This doesn't work as we explicitly downgrade the plexus-archiver.
https://github.com/jboss/jboss-parent-pom/blob/main/pom.xml#L131-L132

e.g.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.2.0:ear (default-ear) on project clusterbench-ee10-ear: Execution default-ear of goal org.apache.maven.plugins:maven-ear-plugin:3.2.0:ear failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-ear-plugin:3.2.0👂 java.lang.NoSuchMethodError: 'void org.codehaus.plexus.archiver.jar.JarArchiver.setMinimalDefaultManifest(boolean)'

I ll open a PR for this.

@dmlloyd
Copy link
Member

dmlloyd commented Sep 19, 2023

@rhusar was this fixed? Edit: now that plexus-archiver is updated, we should be OK. I'm going to test a few things though.

@dmlloyd dmlloyd merged commit 4ba43da into main Sep 19, 2023
@dmlloyd dmlloyd deleted the dependabot/maven/org.apache.maven.plugins-maven-ear-plugin-3.3.0 branch September 19, 2023 15:39
@rhusar
Copy link
Contributor

rhusar commented Sep 19, 2023

@rhusar was this fixed? Edit: now that plexus-archiver is updated, we should be OK. I'm going to test a few things though.

Yeah with #165 should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants