sanitize(data) disabiguation #326
Conversation
…fferent things. Because datatables inherit from AjaxDatatablesRails::ActiveRecord which inherits from AjaxDatatablesRails::Base for some odd reason sanitize binds to ActionView's sanitize method which eventually gets to Loofah and Nokogiri which doesn't handle arrays and throws the error I reported in jbox-web#325 surprisingly even when you call self.sanitize it does not call the method in the same namespace and file!! because technically the sanitize function that we want is AjaxDatatablesRails::Base's function, to disabiguate we could either rename the function (and because I don't know what else calls it that seemed like a bad idea), or we could help disambiguate by being explicit about which super's method to call. The only way I saw to do this is to call it like this: AjaxDatatablesRails::Base.instance_method(:sanitize).bind(self).call(data). That may make for unreadable code to some, we could always define another method that then calls AjaxDatatablesRails::Base.instance_method(:sanitize).bind(self).call(data). Or if you have another way to fix, have at it. But this breaks in Ruby 2.4.0 and rails 5.2.3 for me without this change.
|
Hi there! Thanks for the patch! Since |
|
yeah. I think that's a safer bet. I just assumed it might be referenced by a bunch of other stuff and not mine to rename :). No worries. I appreciate all your hard work on this. |
It might be used by some people who want to use Datatable orthogonal data. But for now it's more a trick than an official supported feature. So let's go for a rename and a line in the changelog ;) |
|
Hi there! Any news? |
|
oh I'm sorry.. sure I can make a new pull request. |
|
OK. I didn't write a test for it but I did verify that the error does not come up. It's a pretty simple tweak so :). Yours to merge and close. |
|
Thank you! |
sanitize is such an overused method name that it binds to a lot of different things. Because datatables inherit from AjaxDatatablesRails::ActiveRecord which inherits from AjaxDatatablesRails::Base for some odd reason sanitize binds to ActionView's sanitize method which eventually gets to Loofah and Nokogiri which doesn't handle arrays and throws the error I reported in #325 surprisingly even when you call self.sanitize it does not call the method in the same namespace and file!! because technically the sanitize function that we want is AjaxDatatablesRails::Base's function, to disabiguate we could either rename the function (and because I don't know what else calls it that seemed like a bad idea), or we could help disambiguate by being explicit about which super's method to call. The only way I saw to do this is to call it like this:
That may make for unreadable code to some, we could always define another method that then calls the above. Or if you have another way to fix, have at it. But this breaks in Ruby 2.4.0 and rails 5.2.3 for me without this change.