Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#65 Setting parameter to SQL NULL instead of String #66

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

piotrkot
Copy link
Contributor

@piotrkot piotrkot commented Jul 4, 2018

Using setNull on PreparedStatement

@0crat
Copy link

0crat commented Jul 4, 2018

@yegor256/z please, pay attention to this pull request

@0crat
Copy link

0crat commented Jul 4, 2018

@piotrkot/z this pull request is too small, just 3 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

@piotrkot
Copy link
Contributor Author

piotrkot commented Jul 9, 2018

@yegor256 ping

@piotrkot
Copy link
Contributor Author

@yegor256 Is there anything I can do to help you with this pull request?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 18, 2018

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8662a7b into jcabi:master Jul 18, 2018
@rultor
Copy link
Contributor

rultor commented Jul 18, 2018

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@yegor256
Copy link
Member

@rultor release, tag is 0.17.1

@rultor
Copy link
Contributor

rultor commented Jul 18, 2018

@rultor release, tag is 0.17.1

@yegor256 OK, I will release it now. Please check the progress here

@0crat
Copy link

0crat commented Jul 18, 2018

Job gh:jcabi/jcabi-jdbc#66 is not assigned, can't get performer

@0crat
Copy link

0crat commented Jul 18, 2018

The job is not in WBS, won't close the order

@rultor
Copy link
Contributor

rultor commented Jul 18, 2018

@rultor release, tag is 0.17.1

@yegor256 Done! FYI, the full log is here (took me 23min)

@piotrkot
Copy link
Contributor Author

@yegor256 Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants