Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#71 Add JdbcSession#rollback() #72

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

golszewski86
Copy link
Contributor

Added JdbcSession#rollback()

@0crat
Copy link

0crat commented Jun 12, 2019

@yegor256/z please, pay attention to this pull request

@0crat 0crat added the scope label Jun 12, 2019
@0crat
Copy link

0crat commented Jun 12, 2019

Job #72 is now in scope, role is REV

@golszewski86
Copy link
Contributor Author

golszewski86 commented Jun 12, 2019

@yegor256 The build on travis failed but for reason not related to the changes I made:

nokogiri requires Ruby version >= 2.3.0. The current ruby version is 2.2.0.
The command "gem install pdd" failed and exited with 1 during .

@0crat
Copy link

0crat commented Jun 12, 2019

@yegor256/z everybody who has role DEV is banned at #72; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 17, 2019

@yegor256/z everybody who has role DEV is banned at #72; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 22, 2019

@yegor256/z everybody who has role DEV is banned at #72; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 27, 2019

@yegor256/z everybody who has role DEV is banned at #72; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 2, 2019

@yegor256/z everybody who has role DEV is banned at #72; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

yegor256 commented Jul 4, 2019

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 4, 2019

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1e433c1 into jcabi:master Jul 4, 2019
@rultor
Copy link
Contributor

rultor commented Jul 4, 2019

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@yegor256
Copy link
Member

yegor256 commented Jul 4, 2019

@rultor release, tag is 0.17.3

@rultor
Copy link
Contributor

rultor commented Jul 4, 2019

@rultor release, tag is 0.17.3

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jul 4, 2019

@rultor release, tag is 0.17.3

@yegor256 Done! FYI, the full log is here (took me 27min)

@0crat
Copy link

0crat commented Jul 4, 2019

Job gh:jcabi/jcabi-jdbc#72 is not assigned, can't get performer

@0crat 0crat removed the scope label Jul 4, 2019
@0crat
Copy link

0crat commented Jul 4, 2019

The job #72 is now out of scope

@0crat
Copy link

0crat commented Jul 4, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @yegor256/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants