Skip to content

Commit

Permalink
(conan-io#24943) thrift: Remove NOMINMAX definition
Browse files Browse the repository at this point in the history
Since thrift/0.12.0 NOMINMAX is not a requirement anymore (THRIFT-4680)
Remove NOMINMAX define as 0.14.1 is the lowest version supported
  • Loading branch information
arnaudmathias authored Aug 14, 2024
1 parent 59ecee3 commit dd6246f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion recipes/thrift/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def package_info(self):
self.cpp_info.components["libthrift"].set_property("pkg_config_name", "thrift")
self.cpp_info.components["libthrift"].libs = [f"thrift{libsuffix}"]
if self.settings.os == "Windows":
self.cpp_info.components["libthrift"].defines.append("NOMINMAX")
if Version(self.version) >= "0.15.0":
self.cpp_info.components["libthrift"].system_libs.append("shlwapi")
elif self.settings.os in ["Linux", "FreeBSD"]:
Expand Down

0 comments on commit dd6246f

Please sign in to comment.