Skip to content

Commit

Permalink
Merge pull request #19 from jchojna/add-fixes
Browse files Browse the repository at this point in the history
Add fixes
  • Loading branch information
jchojna authored Mar 3, 2024
2 parents a6d6ebd + e6e4ef1 commit 4f34eef
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 51 deletions.
16 changes: 3 additions & 13 deletions src/components/Graphic.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,15 @@

.graphic {
align-items: center;
align-self: center;
display: flex;
grid-area: logo;
justify-content: center;
justify-self: start;
margin-top: 50px;
max-width: calc(100% - #{$offset-left-s});
position: relative;
transform-origin: bottom left;
width: 50%;

&.tasktimer {
margin-right: -50px;
}

&.portfolio,
&.quotes,
&.other,
&.contact {
margin-right: -25px;
}
width: 60%;

&.about {
@include graphic(about);
Expand Down
5 changes: 2 additions & 3 deletions src/components/MobileMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,8 @@ const MobileMenu = ({
setIndicatorRef(indicatorRef.current);
const sectionsRefCopy = sectionsRef.current;
if (sectionsRefCopy) {
sectionsRefCopy.addEventListener('mousewheel', handleScroll);
return () =>
sectionsRefCopy.removeEventListener('mousewheel', handleScroll);
sectionsRefCopy.addEventListener('scroll', handleScroll);
return () => sectionsRefCopy.removeEventListener('scroll', handleScroll);
}
}, []); // eslint-disable-line react-hooks/exhaustive-deps

Expand Down
52 changes: 17 additions & 35 deletions src/styles/mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
@mixin section {
align-items: center;
display: flex;
flex-direction: column;
justify-content: center;
min-height: 100vh;
max-height: none;
Expand All @@ -30,7 +31,7 @@

@media only screen and (min-width: $media-m) {
align-items: center;
justify-content: flex-start;
justify-content: center;
padding: 0 50px 0 350px;
}

Expand Down Expand Up @@ -128,21 +129,6 @@
transition: opacity 1s, transform 0.8s cubic-bezier(0, 0.5, 0, 1) 0.2s;
width: 100%;

&.prev {
opacity: 0;
transform: translateY(-100%);
}

&.current {
opacity: 1;
transform: translateY(0);
}

&.next {
opacity: 0;
transform: translateY(100%);
}

&.about {
grid-template-areas:
'photo'
Expand All @@ -156,7 +142,6 @@

&.resume {
grid-template-areas:
'logo'
'title'
'info'
'accordions';
Expand All @@ -168,32 +153,37 @@
&.archviz,
&.quotes {
grid-template-areas:
'logo'
'description'
'demo'
'tags'
'features'
'icons';
}

&.other {
grid-template-areas:
'logo'
'title'
'description'
'otherRepos';
}

&.contact {
grid-template-areas:
'logo'
'title'
'form'
'social'
'footer';
}

@media only screen and (min-width: $media-m) {
&.prev {
opacity: 0;
transform: translateY(-100%);
}

&.current {
opacity: 1;
transform: translateY(0);
}

&.next {
opacity: 0;
transform: translateY(100%);
}

&.about {
grid-template-areas:
'title photo'
Expand Down Expand Up @@ -228,14 +218,6 @@
grid-template-rows: auto 1fr repeat(2, auto);
}

&.other {
grid-template-areas:
'title '
'description'
'otherRepos ';
grid-template-rows: auto 1fr auto;
}

&.contact {
align-content: stretch;
align-items: center;
Expand Down

0 comments on commit 4f34eef

Please sign in to comment.