Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate secrets to credentials #340

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Migrate secrets to credentials #340

merged 1 commit into from
Oct 20, 2023

Conversation

jcraigk
Copy link
Owner

@jcraigk jcraigk commented Oct 20, 2023

This moves the secret_key_base from secrets.yml to credentials to address the following deprecation warning when using load_defaults 7.1:

DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/jcraigk/code/phishin/config/environment.rb:2)

I'm hoping this will also fix production Devise logins, which appear to be broken currently (not able to reproduce locally). Disabling load_defaults 7.1 seems to fix the login issue, which might be a better solution until Devise addresses heartcombo/devise#5644

@jcraigk jcraigk force-pushed the credentials branch 2 times, most recently from b8685d6 to 2969135 Compare October 20, 2023 22:11
@jcraigk jcraigk merged commit 04eb392 into main Oct 20, 2023
4 checks passed
@jcraigk jcraigk deleted the credentials branch October 20, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant