Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Infiniband #74

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add Infiniband #74

merged 1 commit into from
Apr 11, 2024

Conversation

jcronenberg
Copy link
Owner

@jcronenberg jcronenberg commented Feb 8, 2024 •
edited by cfconrad
Loading

Problem

Missing infiniband

Solution

Add Infiniband
Fixes #35

Testing

  • Added a new unit test
  • Added new integration tests
  • Tested manually

@jcronenberg jcronenberg added upstream Something needs to be changed/implemented upstream migration Something needs to be changed/implemented in the wicked migration labels Feb 8, 2024
@jcronenberg jcronenberg modified the milestone: YaST2 lan parity Feb 8, 2024
@coveralls
Copy link

coveralls commented Feb 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8618621015

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+3.0%) to 54.646%
Files with Coverage Reduction New Missed Lines %
rust/src/interface.rs 14 86.51%
rust/src/main.rs 15 0.0%
Totals Coverage Status
Change from base Build 8615961500: 3.0%
Covered Lines: 247
Relevant Lines: 452
💛 - Coveralls

@jcronenberg jcronenberg changed the title Infiniband Add Infiniband Feb 8, 2024
@jcronenberg jcronenberg force-pushed the infiniband branch 2 times, most recently from 1a072cb to 04cef32 Compare February 8, 2024 14:35
@jcronenberg jcronenberg mentioned this pull request Feb 8, 2024
Merged
imobachgs added a commit to agama-project/agama that referenced this pull request Apr 2, 2024
@imobachgs
Add infiniband to network model (#1032)
e63f418 
## Problem

No infiniband in network model

## Solution

Add infiniband to network model

## Testing

- *Added a new unit test*
- *Tested manually*
- *Tested using the migration
jcronenberg#74
@jcronenberg jcronenberg marked this pull request as ready for review April 9, 2024 15:54
cfconrad
cfconrad approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfconrad cfconrad merged commit f3315c4 into wicked-nm-migration Apr 11, 2024
4 checks passed
@jcronenberg jcronenberg deleted the infiniband branch June 12, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfconrad cfconrad cfconrad approved these changes

Assignees
No one assigned
Labels
migration Something needs to be changed/implemented in the wicked migration upstream Something needs to be changed/implemented upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Infiniband
3 participants
@jcronenberg @coveralls @cfconrad