fix(browser): return early if response headers empty #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing simple requests, such as
```ts
import { Gitlab } from "@gitbeaker/browser";
const api = new Gitlab({ token, host });
const res = await api.Issues.show(projectId, issueIid);
```
I used to get errors, such as
```console
index.js:11539 RangeError: Invalid array length
at ./gitbeaker/packages/gitbeaker-browser/src/KyRequester.ts.__spreadArrays (index.js:155)
at responseHeadersAsObject (index.js:169)
at index.js:224
at step (index.js:148)
at Object.next (index.js:129)
at fulfilled (index.js:120)
(anonymous) @ index.js:11539
step @ index.js:11488
(anonymous) @ index.js:11469
rejected @ index.js:11461
Promise.then (async)
step @ index.js:11462
(anonymous) @ index.js:11463
./source/features/add-grid-for-current-column-label.tsx.__awaiter @ index.js:11459
addGridForCurrentColumnLabel @ index.js:11520
(anonymous) @ index.js:11375
step @ index.js:11345
(anonymous) @ index.js:11326
fulfilled @ index.js:11317
Promise.then (async)
step @ index.js:11319
(anonymous) @ index.js:11320
./source/Features.ts.__awaiter @ index.js:11316
(anonymous) @ index.js:11369
(anonymous) @ index.js:11380
./source/Features.ts.Features.loadAll @ index.js:11363
globalInit @ index.js:11810
./source/refined-gitlab.ts @ index.js:11667
__webpack_require__ @ index.js:20
./source/index.ts @ index.js:11637
__webpack_require__ @ index.js:20
(anonymous) @ index.js:84
(anonymous) @ index.js:87
```
and this fixed it.
|
Forgot to add the correct tag before merging! This will be included in the next triggered release 🙏 sorry!! |
|
🚀 PR was released in |
kiprasmel
pushed a commit
to kiprasmel/refined-gitlab
that referenced
this pull request
Aug 9, 2020
jdalrymple/gitbeaker#1034 Signed-off-by: Kipras Melnikovas <[email protected]>
kiprasmel
pushed a commit
to kiprasmel/refined-gitlab
that referenced
this pull request
Aug 9, 2020
jdalrymple/gitbeaker#1034 Signed-off-by: Kipras Melnikovas <[email protected]>
|
cheers m8, thanks for the great project! hopefully will be able to implement some cool stuff with it @ refined-gitlab :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing simple requests, such as
I used to get errors, such as
and this fixed it.
__spreadArraysrefers to theconst keyVals = [...response.headers.entries()]line's array spread when the headers are empty ({})(I'm using
gitbeaker's direct source code as a git submodule instead of via npm because I tried both rollup & webpack and couldn't compilegitbeakerto work inside a browser extension. It's generally better to not compile libraries and leave it up to the final application, but whatever, I don't mind, and was able to fix this quicker - cheers)