Declare Groups API allProjects function default type first (#3624)
#3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudTA
force-pushed
the
fix/all-projects-types
branch
from
101c2eb
to
443f275
Compare
ArnaudTA
force-pushed
the
fix/all-projects-types
branch
from
443f275
to
429b485
Compare
jdalrymple
changed the title
allProjects function default type first (#3624)
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello in you code the return of
allProjectsisCondensedProjectSchema[].Apparently for ts if no options are provided it matches the first signature.
So I just interved the two signatures to be closer to the api default behavior
ps: topics can be
nullin your schema but i don't see anything on it in the documentation. Feel free to edit my pr to remove it if you think it is a good idea.