Refactor artifact configuration to distinct classes #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Outdated PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor artifact code into subclasses where the superclass is an abstract class of abc.ABC - this is in line with Chaos' review comments on Remove Blob_SAS_URL Option from ArmTemplate in input file by jordlay · Pull Request #119 · jddarby/azure-cli-extensions (github.com), which I decided not to implement due to it being GA release day and it was a bit bigger than I was comfortable with.
This PR needs to be merged post-GA into "wherever it is we are merging PRs after that", with a change to History.rst.
There is no change to the interface of input.json so no version bump required.