Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watermark): support multi-line text #2477

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Jul 23, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能

    • 更新了水印组件,支持多种状态显示,包括文本、图像和多行文本水印。
    • 新增startXstartY属性,允许用户自定义水印的起始位置。
  • 文档

    • 增强了水印组件的文档,明确支持单行文本、多行文本和图像。
    • 改进了文档格式,提高可读性,添加了新的属性描述。

Copy link

coderabbitai bot commented Jul 23, 2024

Walkthrough

此次修改显著提升了 WaterMark 组件的功能与灵活性。通过将状态管理从布尔值更改为整数,组件现在能够支持多种水印显示模式。此外,文档也得到了增强,提供了更清晰的使用说明和新属性的详细介绍,提升了用户体验。

Changes

文件 更改摘要
src/packages/watermark/demos/h5/demo1.tsx 修改 flag 状态为整数,支持多种水印显示模式。更新按钮点击处理和条件渲染逻辑。
src/packages/watermark/demos/taro/demo1.tsx 同上,增强了与用户交互的响应,支持不同的水印内容及属性。
src/packages/watermark/doc.en-US.md 拓展“基本用法”部分,新增 startXstartY 属性说明,改善示例格式。
src/packages/watermark/doc.md 添加水印支持多种文本和图像的说明,格式优化,新增 startXstartY 属性。
src/packages/watermark/doc.taro.md 明确水印组件的功能,添加 startXstartY 属性说明,清理示例代码格式。
src/packages/watermark/doc.zh-TW.md 增加水印功能支持的描述,新增 startXstartY 属性说明。
src/packages/watermark/watermark.taro.tsx WaterMarkProps 接口中新增 startXstartY 属性,更新渲染逻辑。
src/packages/watermark/watermark.tsx 同上,增强组件灵活性,允许动态定位水印文本。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DemoComponent
    participant WaterMark

    User->>DemoComponent: 点击按钮 (设置 flag)
    DemoComponent->>WaterMark: 根据 flag 渲染水印
    alt flag == 0
        WaterMark->>User: 显示水印内容 "NutUI-WaterMark"
    else flag == 1
        WaterMark->>User: 显示水印图像
    else flag == 2
        WaterMark->>User: 显示多行文本和多个水印
    end
Loading

Poem

🐰 在水印间跳跃,
新属性如星闪耀,
代码轻轻舞动,
用户欢悦笑,
功能更强,体验好,
兔子庆祝,咕咕叫! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xiaoyatong xiaoyatong requested a review from irisSong July 23, 2024 09:02
@xiaoyatong xiaoyatong linked an issue Jul 23, 2024 that may be closed by this pull request
@oasis-cloud oasis-cloud merged commit 472fe69 into jdf2e:next Jul 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用WaterMark实现多行水印
2 participants