Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): allow custom classnames for Menu and dynamic titles #2480

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Jul 24, 2024

支持使用者灵活控制nut-menu与nut-menu-title的样式。

  1. 传入的classname默认控制nut-menu
  2. 通过我们提供的title${index}类名,控制title
  • 新特性提交

Summary by CodeRabbit

  • 样式
    • 优化了菜单组件的 className 属性,提升了可读性和可能的性能。

Copy link

coderabbitai bot commented Jul 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次更改对 Menu 组件的 className 属性进行了精简和优化,旨在提高代码可读性和性能。通过消除多余的空格并直接将 index 连接到类名字符串中,创建类名的过程变得更加简洁。功能逻辑保持不变,这些修改主要是外观上的改善,同时也呼应了用户反馈的问题。

Changes

文件 更改摘要
src/packages/menu/menu.taro.tsx
src/packages/menu/menu.tsx
精简 className 属性的构建,去除多余空格,直接将 index 连接到类名中。

Possibly related issues

  • Menu 组件 className 属性使用混乱 #2478: 该问题提到 Menu 组件的 className 属性使用混乱,认为应将外部传入的 className 仅应用于 nut-menu,而不是每个 nut-menu-title,与本次修改的方向一致。

Poem

🐇 在草地上蹦蹦跳,
优化代码真美好,
类名简洁不再乱,
功能依旧乐逍遥。
小兔欢呼声声响,
代码清晰心情好! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Alex-huxiyang Alex-huxiyang linked an issue Jul 24, 2024 that may be closed by this pull request
@xiaoyatong xiaoyatong merged commit f853081 into jdf2e:next Jul 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu 组件 className 属性使用混乱
2 participants