-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: taro async warning in taro-h5 env #2636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2636 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 219 219
Lines 17914 17914
Branches 2549 2549
=======================================
Hits 14867 14867
Misses 3042 3042
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Walkthrough此次更改主要涉及 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/nutui-taro-demo/config/index.js (1)
109-113
: H5输出配置的更改看起来不错新增的H5输出配置
output.environment.asyncFunction: true
似乎直接解决了PR的目标,即修复Taro H5环境中的异步警告。这个更改启用了输出环境中对异步函数的支持,这很可能解决了原有的警告问题。建议在项目文档中添加关于这个配置更改的说明,以便其他开发者了解这个变更及其目的。
🤔 这个变动的性质是?
#15597
Summary by CodeRabbit
Summary by CodeRabbit