Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbar 标签栏Icon支持插槽 #1807

Closed
yanbowe opened this issue Nov 1, 2022 · 2 comments
Closed

Tabbar 标签栏Icon支持插槽 #1807

yanbowe opened this issue Nov 1, 2022 · 2 comments
Assignees
@Drjingfubo

Comments

@yanbowe
Copy link

yanbowe commented Nov 1, 2022

What problem does this feature solve?（这个功能解决的问题）

项目中接入了@iconify/json icon ，目前Tabbar 栏不支持插槽，无法使用iconify中的图标，有点不太友好

What does the proposed API look like?（期望的 API）

slot插槽#icon
@Drjingfubo Drjingfubo self-assigned this Nov 2, 2022
@Drjingfubo Drjingfubo moved this to In Progress in nutui-vue 社区任务列表 Nov 2, 2022
@yanbowe
Copy link
Author

yanbowe commented Nov 4, 2022 •
edited
Loading

nutui其他组件中的icon可否都支持插槽，例如menu，Collapse，Progress等组件

@Drjingfubo
Copy link
Contributor

nutui其他组件中的icon可否都支持插槽，例如menu，Collapse，Progress等组件

好的 我们统一看下有用到icon组件的

Drjingfubo added a commit that referenced this issue Nov 17, 2022
@Drjingfubo
fix(tabbar): add custom Icon slot #1807 (#1852)
c489132
@szg2008 szg2008 closed this as completed Nov 18, 2022
Repository owner moved this from In Progress to Done in nutui-vue 社区任务列表 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Drjingfubo Drjingfubo

Labels
None yet
Projects
nutui-vue 社区任务列表
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szg2008 @yanbowe @Drjingfubo