Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): resolve tabpane show errors #1544 #1636

Merged
merged 52 commits into from
Sep 6, 2022
Merged

Conversation

Drjingfubo
Copy link
Contributor

No description provided.

@Drjingfubo Drjingfubo merged commit d1c6906 into jdf2e:next Sep 6, 2022
@Drjingfubo Drjingfubo mentioned this pull request Sep 7, 2022
@wangfpp
Copy link

wangfpp commented Sep 13, 2022

@Drjingfubo 大哥你的这段代码 直接修改了panKey的数据类型呀 这个key到底是String还是Number

title.paneKey = paneIndex || camelPaneIndex || String(index);  

@Drjingfubo
Copy link
Contributor Author

@Drjingfubo 大哥的这段代码直接修改了panKey的数据类型呀key到底是String还是Number

title.paneKey = paneIndex || camelPaneIndex || String(index);  

组件最上边已经定义了title.paneKey的类型
image

@wangfpp
Copy link

wangfpp commented Sep 13, 2022

@Drjingfubo 大哥的这段代码直接修改了panKey的数据类型呀key到底是String还是Number

title.paneKey = paneIndex || camelPaneIndex || String(index);  

组件最上边已经定义了title.paneKey的类型 image

我记得以前是Number 修复了一个bug之后变成了String 改动数据的影响很大 希望changedlog上能够有体现 谢谢

@Drjingfubo
Copy link
Contributor Author

@Drjingfubo 大哥的这段代码直接修改了panKey的数据类型呀key到底是String还是Number

title.paneKey = paneIndex || camelPaneIndex || String(index);  

组件最上边已经定义了title.paneKey的类型 image

我记得以前是Number 修复了一个bug之后变成了String 改动数据的影响很大 希望changedlog上能够有体现 谢谢

上方定义的类型一直没变过,你可以看下提交记录

@Drjingfubo
Copy link
Contributor Author

@Drjingfubo 大哥的这段代码直接修改了panKey的数据类型呀key到底是String还是Number

title.paneKey = paneIndex || camelPaneIndex || String(index);  

组件最上边已经定义了title.paneKey的类型 image

我记得以前是Number 修复了一个bug之后变成了String 改动数据的影响很大 希望changedlog上能够有体现 谢谢

我明白兄弟你的意思,我们后边标注的更清晰一点。
不过这个改动貌似不会影响到使用吧,你说的改动数据影响很大是指什么呀

@wangfpp
Copy link

wangfpp commented Sep 14, 2022

@Drjingfubo 大哥的这段代码直接修改了panKey的数据类型呀key到底是String还是Number

title.paneKey = paneIndex || camelPaneIndex || String(index);  

组件最上边已经定义了title.paneKey的类型 image

我记得以前是Number 修复了一个bug之后变成了String 改动数据的影响很大 希望changedlog上能够有体现 谢谢

我明白兄弟你的意思,我们后边标注的更清晰一点。 不过这个改动貌似不会影响到使用吧,你说的改动数据影响很大是指什么呀

我看了代码类型声明确实是String 代码的内部逻辑确实有string | number的地方
image

@wangfpp
Copy link

wangfpp commented Sep 14, 2022

我们的逻辑如下:

<nut-tab v-model:"tab.current"></nut-tab>
<div v-for="(item, index) in listData">
     <component v-if="tab.current === index" ></component>
</div>

因为v-if使用了严格判断所以出错了 我们修改了v-if="Number(tab.current) === index"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants