Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uploader): add delete-icon prop #1841

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Conversation

gyt95
Copy link
Member

@gyt95 gyt95 commented Nov 11, 2022

这个 PR 做了什么? (简要描述所做更改)

新增delete-icon属性,支持自定义删除按钮,可传入图标名称或图片链接。

已包含测试用例、文档描述。

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • NutUI 2.0
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

Copy link
Member

@richard1015 richard1015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一下 v-bind="$attrs" 方便自定义iconfont 使用外部 icon
参考 https://github.com/jdf2e/nutui/blob/next/src/packages/__VUE/cell/template.html#L5

@gyt95
Copy link
Member Author

gyt95 commented Nov 15, 2022

加一下 v-bind="$attrs" 方便自定义iconfont 使用外部 icon 参考 https://github.com/jdf2e/nutui/blob/next/src/packages/__VUE/cell/template.html#L5

好的已补充,请查看

@richard1015 richard1015 merged commit 9caa103 into jdf2e:next Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants