Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tabs数量多,滚动操作 doc 更新 #2158

Merged
merged 3 commits into from
Mar 9, 2023
Merged

docs: tabs数量多,滚动操作 doc 更新 #2158

merged 3 commits into from
Mar 9, 2023

Conversation

n0liu
Copy link
Contributor

@n0liu n0liu commented Mar 5, 2023 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • NutUI 2.0
  • NutUI 3.0 H5
  • NutUI 3.0 小程序
  • NutUI 4.0 H5
  • NutUI 4.0 小程序

这个 PR 是否已自测:

@richard1015 richard1015 requested a review from gyt95 March 6, 2023 02:31
gyt95
gyt95 suggested changes Mar 6, 2023
View reviewed changes
Copy link
Member

@gyt95 gyt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议只改 <script> 里的名称，把 tab1value 改为 tab4value ，和 list4 对应。

@n0liu
Copy link
Contributor Author

n0liu commented Mar 9, 2023

建议只修改 <script> 里的名称，把 tab1value 修改为 tab4value ，和 list4 对应。
ok, 已经从新修改完成

@n0liu n0liu requested a review from gyt95 March 9, 2023 04:01
@richard1015 richard1015 merged commit d64bbdc into jdf2e:v4 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyt95 gyt95 gyt95 approved these changes

@richard1015 richard1015 richard1015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n0liu @richard1015 @gyt95