Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(countdown): millisecond format #2514

Merged
merged 4 commits into from
Aug 28, 2023
Merged

fix(countdown): millisecond format #2514

merged 4 commits into from
Aug 28, 2023

Conversation

subordon
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复 countdown 格式化展示渲染为毫秒(1位)时显示异常 #2512
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@eiinu
Copy link
Member

eiinu commented Aug 28, 2023

可以顺便修改一下 index.taro.vue 文件中存在的同样的问题

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2514 (32bba01) into v4 (e952243) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v4    #2514      +/-   ##
==========================================
+ Coverage   84.78%   84.87%   +0.09%     
==========================================
  Files         149      149              
  Lines       20435    20435              
  Branches     2270     2274       +4     
==========================================
+ Hits        17325    17344      +19     
+ Misses       3105     3086      -19     
  Partials        5        5              
Files Changed Coverage Δ
src/packages/__VUE/countdown/index.vue 90.47% <100.00%> (+6.95%) ⬆️

@eiinu eiinu merged commit 923ddb3 into jdf2e:v4 Aug 28, 2023
5 checks passed
@eiinu eiinu linked an issue Aug 28, 2023 that may be closed by this pull request
@subordon subordon deleted the feat/test branch August 29, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

countdown 格式化展示渲染为毫秒(1位)时显示异常
2 participants