feat(calendar): 日历底部增加插槽 #2550
Merged
feat(calendar): 日历底部增加插槽 #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 这样可以支持自定义底部区域按钮，而非简单的文字替换 2. 更多样化的确认操作，用户选择日期后可以查接口等等再选择关闭弹窗 3. 用最小的代码量扩展更多的自由度，而且一点不影响其他功能
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v4 #2550 +/- ##
==========================================
+ Coverage 84.82% 84.83% +0.01%
==========================================
Files 150 150
Lines 20508 20517 +9
Branches 2280 2284 +4
==========================================
+ Hits 17396 17406 +10
+ Misses 3107 3106 -1
Partials 5 5
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
eiinu
reviewed
Sep 8, 2023
| @@ -46,6 +46,9 @@ | |||
| <template v-if="bottomInfo" #bottom-info="date"> | |||
| <slot name="bottom-info" :date="date.date"> </slot> | |||
| </template> | |||
| <template v-if="footerInfo" #footer-info="date"> | |||
| <slot name="footer-info" :date="date.date"> </slot> | |||
| </template> | |||
| </nut-calendar-item> | |||
| </nut-popup> | |||
| <nut-calendar-item | |||
There was a problem hiding this comment.
下面有另一种方式使用的 calendar-item，也需要增加同样的逻辑
涉及 index.vue/index.taro.vue 两个文件
There was a problem hiding this comment.
下方是不需要加的，因为这种底部插槽的展示形式需要配合弹窗pop使用，平铺展示一般来说没这种需求
eiinu
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
feat(calendar): 日历底部增加插槽
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: