Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pullrefresh): 新增一个刷新成功/刷新状态的插槽(#2636) #2639

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

yi-boide
Copy link
Contributor

@yi-boide yi-boide commented Nov 6, 2023

这个 PR 做了什么? (简要描述所做更改)
pullrefresh 新增一个刷新成功/刷新状态的插槽

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (272ce3d) 85.02% compared to head (d2a64b3) 85.00%.

Files Patch % Lines
src/packages/__VUE/pullrefresh/index.vue 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2639      +/-   ##
==========================================
- Coverage   85.02%   85.00%   -0.02%     
==========================================
  Files         152      152              
  Lines       20999    21012      +13     
  Branches     2351     2355       +4     
==========================================
+ Hits        17854    17861       +7     
- Misses       3140     3146       +6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu added this to the v4.2.1 milestone Nov 6, 2023
@eiinu eiinu linked an issue Nov 6, 2023 that may be closed by this pull request
@eiinu eiinu modified the milestones: v4.2.1, v4.2.2 Nov 9, 2023
@eiinu
Copy link
Member

eiinu commented Nov 14, 2023

为了兼容升级,需要将该插槽的默认值设置为空。

@eiinu eiinu merged commit e5dcce6 into jdf2e:v4 Nov 17, 2023
3 of 5 checks passed
@yi-boide yi-boide deleted the pullrefresh-complete branch March 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pullrefresh]: 建议新增一个刷新成功/刷新状态的插槽
2 participants